feat(cli,contract): --reviewer and --qa on ceki contract create#7
Open
iWedmak wants to merge 6 commits into
Open
feat(cli,contract): --reviewer and --qa on ceki contract create#7iWedmak wants to merge 6 commits into
ceki contract create#7iWedmak wants to merge 6 commits into
Conversation
Backend create-contract-event now accepts explicit reviewer/qa objects
({type, value}); without them the event stays a clean Hand. Expose the
same surface on the CLI + SDK: matching shape to --benefitable
(agent:N / user:N), only forwarded into the payload when supplied.
Tests: regression cases for the contract client (reviewer-only, qa-only,
both, neither) plus a CLI parser dispatch case wiring all three through.
Backend moved role pivots into a single participants array of
{value, type, role_id} items (reviewer -> role 5, qa -> role 6).
Drop the old top-level reviewer/qa keys, keep --reviewer / --qa
on the CLI as the human-facing shortcut, and add a repeatable
--participant for arbitrary roles.
Version bumped to 2.27.0 - wire format is breaking.
`propose --desc` was being used as a progress report, but the backend treats --desc as the event description — agents were silently wiping the spec. Add a dedicated `progress` command that wraps a status correction (optional --status) and a comment in one call, leaving the event description untouched. `propose` semantics are unchanged. SKILL.md updated to recommend `progress` for status+report; `propose` stays for pure field corrections. Version bumped to 2.28.0.
Backend rejects comment events without a `label` ("The label field is
required"). The bare `progress` call hit this on first dogfood. Derive
a short label from the first line of --desc (capped at 60 chars); fall
back to "progress" if desc is empty. The full --desc still goes into
`description` untouched.
Backend rejects {value, type, role_id} with 422 — the wire shape per
EventController validation rules is {participable_id, participable_type,
role_id}. role_id mapping (reviewer=5, qa=6) is unchanged.
Unit tests previously asserted the wrong shape; regression guard
test_create_participants_uses_participable_id_keys() now pins the
correct keys. Patch bump to 2.28.1.
Backend renamed the role-attachment array field from `participants` to
`users` (sync with back/2542). Element shape stays
{participable_id, participable_type, role_id}. CLI flag --participant
keeps its name — it is the human-facing word; only the wire key moves.
Regression guard test_create_uses_users_field_not_participants pins the
field name. Minor bump to 2.29.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backend create-contract-event now accepts explicit
reviewerandqaobjects (task 2465 backed by back/2442). Without them the event stays a clean Hand role. Expose the same surface on the CLI + SDK:ceki contract create CID --benefitable agent:N --reviewer agent:M --qa agent:Kattaches both roles.--reviewer/--qaaccept the sameagent:N/user:Nform as--benefitable.ContractClient.create()gets the matchingreviewer=/qa=kwargs.No backwards-incompatible change — every existing call site keeps working.
Test plan
ruff check .— All checks passedpytest tests/test_contract.py— 46/46 green; includes 4 new regression cases (reviewer-only, qa-only, both, CLI parser+dispatch)ceki contract create --helpshows the two new flags afterpip install -e .